wisp-gg / frontend

The frontend for WISP Game Panel
https://wisp.gg
MIT License
42 stars 15 forks source link

Implement Modrinth Mod Pack format and list #305

Open n-aspen opened 2 years ago

n-aspen commented 2 years ago

Describe the feature and why you would like to see it.

Modrinth is an open-source CurseForge alternative that's working on a similarly open Mod Pack format. It has plans to support using any service to host the mod files, and currently does but Modrinth itself limits to a select number of download locations. The format also allows separating data into server and client data and mods.

By all appearances this project has been doing incredibly well and has a lot of promise to unify current and future mod hosts.

Describe the solution you'd like.

The ability to upload and install Modrinth Format packs (or .mrpack files) and install packs from the Modrinth website using the existing Mod Pack Installer.

By defult only these domains are allowed on Modrinth

cdn.modrinth.com
github.com
raw.githubusercontent.com
gitlab.com

But it would be useful to be able to modify that list should it change or a custom location be wanted.

Optional additional context to this request.

This is Modrinth's page on their Mod Pack Format https://docs.modrinth.com/docs/modpacks/format_definition/

and this is their list of Mod Packs https://modrinth.com/modpacks

TrixterTheTux commented 2 years ago

Is there any specific reason why the uploading part should be implemented on the panel's side? Modrinth already recommends tools made for this (https://docs.modrinth.com/docs/modpacks/creating_modpacks/#how-do-i-create-a-modpack), so essentially reimplementing them in the panel doesn't make much sense (nor does it make much sense to do it from the panel itself vs. locally to me at least).

n-aspen commented 2 years ago

My reasoning was that since it's goal is to be an open format I didn't want to be reliant on the existing platform and allow for users and hosts to use their own mod sources, which wouldn't be possible if packs could only be downloaded from Modrinth.

I'm not sure why you linked creating a Mod Pack? I figured this would just be reading mrpack files that are uploaded by the user instead of downloaded from the Modrinth list. But I'm not sure on the details there.

Looking again at the current implementation for CurseForge packs I see that you can't upload their pack files, so this might not be something that fits right now.

TrixterTheTux commented 2 years ago

Oh, I misinterpreted the "uploading" as in being able to upload modpacks to Modrinth from the panel, instead of being able to upload modpack specification for the panel to download. Makes sense now.

Currently, I'm planning on having support for most of the platforms (ATLauncher, FTB, Technic) after the current system gets tested for stability, so I'm not sure if it's worthwhile on allowing specifications to be uploaded on top of being able to directly use the platform (and the specification isn't parsed on the daemon either, so we'd need to make a separate system to accomplish that).

n-aspen commented 2 years ago

Ah, that makes sense, sorry about the confusion there. If that part isn't ideal right now then support for the Modrinth Platform would be a better direction for this suggestion, which it sounds like you already have a list of Platforms you plan to add support for.

larsjarred9 commented 1 year ago

Modrinth would be a good nice-to-have

Shybella commented 5 months ago

Modrinth would be a good nice-to-have