search

wisp-gg / frontend

The frontend for WISP Game Panel
https://wisp.gg
MIT License
42 stars 15 forks source link

Backup schedule can crash an entire node #356

Closed Larsdeijsbeer closed 1 year ago

Larsdeijsbeer commented 1 year ago

Describe the bug

The scheduler is able to start the creation of a backup while another backup is still running. This creates a loop of backups which can cause an entire node to crash. I've experienced this multiple times.

Expected Behavior

Don't start multiple backup processes. It shouldn't ignore the user limits (like disk size limit)

Actual Behavior

It completely fills the disk (even when the user has a 20GB backup limit). So it ignores the user limits. Because it starts creating a lot of backups this also causes full cpu utilization on the node. Even when the user has a limit of 200%.

Disk usage (node) image

A lot of backups are running at the same time image

Steps to Reproduce

Create a schedule like this: image

It should create a backup every minute.

Browser Details

Chrome

Operating System

Windows 10

Optional additional information

Have fun crashing hosts using Wisp!

TrixterTheTux commented 1 year ago

Backup creation should be throttled in the next release to 2 backups/10 minutes