Output - Githubissues

wisp-lang / wisp

A little Clojure-like LISP in JavaScript

https://gozala.github.io/wisp/

Other

982 stars 68 forks source link

Output #98

Open xkxx opened 10 years ago

xkxx commented 10 years ago

I would like to add an --output flag to the compiler along with the ability to compile multiple files at once, for the following reasons:

Familiarity. Most compilers I've seen have this option. It's natural to try to use -o for outputting files. coffee-script, rustc, gcc, nimrod, javac, to list some examples
Ease of use inside terminal. Say you are just wanting to compile a three odd files and don't want to use a build system yet. wisp a.wisp b.wisp c.wisp -o ./ is a lot easier to type than repeatedly pushing the up arrow to retrieve the last three commands
Simplicity It's a lot less likely to make typos like " > test.jjs" if the compiler handles it
CoffeeScriptRedux does have a output flag https://github.com/michaelficarra/CoffeeScriptRedux/blob/master/src/cli.coffee#L148
It does not really add much code to the compiler, just 12 lines.

davidchambers commented 10 years ago

Thanks for correcting my error, @xkxx. I misremembered a discussion. The thing CSR does not do is create directories: -o does/not/exist results in an error.

Gozala commented 10 years ago

Fine by me, but this is no longer up to date as I had to fix regressions introduced by #97

Also --print flag and --output flags are incompatible and should not be allowed together as writing AST into .js file does not makes much sense to me.

xkxx commented 10 years ago

I've merged upstream changes. There seems to be a problem with --print handling that appends the input by "code". Removing str fixes the problem. The merge log looks very messy, though, for some reason.

Gozala commented 10 years ago

I am afraid this still appears as "We can’t automatically merge this pull request." so probably there is merge conflict that needs to be resolved. I'd say you need to merge with upstream as I don't see such a commit here that's what I think is causes issues.

xkxx commented 10 years ago

Hum, that's weird. I will open a fresh fork and see if that fixes it.

xkxx commented 10 years ago

How about now?

Gozala commented 10 years ago

Now it looks mergable, but I would like to test this time around to make sure nothing breaks. I'll merge once I'll run tests ;)

Thanks

Gozala commented 9 years ago

@xkxx I appologise this project has definitely went undermaintained for quite some time now. I beleive I'm back on track now, I'll try to respond with any open issues with in the week & go through all open pulls (including this one) this week.