wispborne / TriOS

Starsector mod manager & toolkit.
https://fractalsoftworks.com/forum/index.php?topic=29674.0
GNU General Public License v3.0
14 stars 1 forks source link

TriOS "Update" button on toast remains greyed-out and unclickable after downloading an update #51

Closed nissa-seru closed 4 months ago

nissa-seru commented 4 months ago

Minor bug, flagging in case helpful. Screenshot 2024-07-23 120651

latest.log

wispborne commented 4 months ago

Read config from File: 'C:\WINDOWS\system32\cache\TriOS-VersionCheckerCache.json': 0 entries.

Somehow, the Directory.current variable is getting set to system32. It's been happening to quite a few people. No idea why yet.

nissa-seru commented 4 months ago

Hmm, that feels related to TriOS being run as admin.

On Tue, Jul 23, 2024 at 2:56 PM Wisp @.***> wrote:

Read config from File: 'C:\WINDOWS\system32\cache\TriOS-VersionCheckerCache.json': 0 entries.

Somehow, the Directory.current variable is getting set to system32. It's been happening to quite a few people. No idea why yet.

— Reply to this email directly, view it on GitHub https://github.com/wispborne/TriOS/issues/51#issuecomment-2246011713, or unsubscribe https://github.com/notifications/unsubscribe-auth/A4NBSEVHSZQVTBZHD43ALD3ZN2RMTAVCNFSM6AAAAABLKX5GNGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENBWGAYTCNZRGM . You are receiving this because you authored the thread.Message ID: @.***>

nissa-seru commented 4 months ago

Another data point in case helpful; I ran into the same issue again a few minutes ago (on TriOS v0.1.3) when I tried to use the "Add mod" feature. Restarted TriOS, did not resolve. However, while digging, I noticed that TriOS had created "cache" and "logs" folders in the Start Menu folder containing the shortcut that I usually use to run TriOS - this prompted a bit of deja vu, since it'd happened to me before when running a script from a shortcut previously; in that instance, the directory containing the shortcut was being considered by my script as the current directory. Sure enough, directly running TriOS from the folder where I had previously extracted it (without using the shortcut) resolved the issue. Wondering if a chdir/context manager or similar is just needed to set the working directory to the location of the TriOS executable.

On Tue, Jul 23, 2024 at 5:21 PM Nissa Seru @.***> wrote:

Hmm, that feels related to TriOS being run as admin.

On Tue, Jul 23, 2024 at 2:56 PM Wisp @.***> wrote:

Read config from File: 'C:\WINDOWS\system32\cache\TriOS-VersionCheckerCache.json': 0 entries.

Somehow, the Directory.current variable is getting set to system32. It's been happening to quite a few people. No idea why yet.

— Reply to this email directly, view it on GitHub https://github.com/wispborne/TriOS/issues/51#issuecomment-2246011713, or unsubscribe https://github.com/notifications/unsubscribe-auth/A4NBSEVHSZQVTBZHD43ALD3ZN2RMTAVCNFSM6AAAAABLKX5GNGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENBWGAYTCNZRGM . You are receiving this because you authored the thread.Message ID: @.***>

wispborne commented 4 months ago

Hah. 18ae9f6ffc0a8fb5b8237934c9daa45a81310250

Wondering if a chdir/context manager or similar is just needed to set the working directory to the location of the TriOS executable.

That's exactly what I decided to do. I was never able to reproduce this bug, even after making a shortcut and launching from there, but I'm hopefully this will fix it.

wispborne commented 4 months ago

TriOS-0.1.4.zip

If the issue is still happening, does this fix it? You can overwrite the existing install.

wispborne commented 4 months ago

Hopefully fixed in 18ae9f6ffc0a8fb5b8237934c9daa45a81310250

nissa-seru commented 4 months ago

Cool, thanks for the speedy fix. With 0.1.4, I'm seeing logs/cache folders being created in the correct place (location of the exe, not the shortcut), and I can no longer repro the system32 issue, so lgtm!

On Thu, Jul 25, 2024 at 2:36 AM Wisp @.***> wrote:

Hopefully fixed in 18ae9f6 https://github.com/wispborne/TriOS/commit/18ae9f6ffc0a8fb5b8237934c9daa45a81310250

— Reply to this email directly, view it on GitHub https://github.com/wispborne/TriOS/issues/51#issuecomment-2249566299, or unsubscribe https://github.com/notifications/unsubscribe-auth/A4NBSEQG2SYOOIC3H55X2G3ZOCMGVAVCNFSM6AAAAABLKX5GNGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENBZGU3DMMRZHE . You are receiving this because you authored the thread.Message ID: @.***>