Update submodule locations

wispproject / wallet

Wisp wallet

https://wispproject.com/

MIT License

7 stars 2 forks source link

Update submodule locations #3

Open bitcoinx2 opened 6 years ago

bitcoinx2 commented 6 years ago

Submodule 'db4.8' (https://github.com/XSPECOfficial/db4.8) registered for path 'db4.8'
Submodule 'leveldb' (https://github.com/XSPECOfficial/leveldb) registered for path 'leveldb'
Submodule 'tor' (https://github.com/spectrecoin/tor.git) registered for path 'tor'

~~The XSPECOfficial repository should probably be removed~~
The Tor submodule should not refer to a repository that is maintained by a different development team, since it might introduce incompatibilities

bitcoinx2 commented 6 years ago

Partially solved by https://github.com/wispproject/wallet/pull/5 by @sinfulhands , thanks!

Is referring to the Spectrecoin repository actually a problem?

sinfulhands commented 6 years ago

It's not ideal. You run a risk as the two projects diverge of having one of three possibilities occurring.

One, they take the repo private.
Two, master of one of the repos is somehow altered to account for a change on the spectrecoin project that wisp has not developed for, which creates an external dependency.
Or three, nothing happens.

But, it's best to mitigate risk. Anyone with wisp project access should be able to fork the three repos and just change the git submodule url string.