search

wisskar / souliss

Automatically exported from code.google.com/p/souliss
0 stars 0 forks source link

Power Off on Toggle Command when T16 is Timed #103

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
Branch name: ??

Purpose of code changes on this branch:
I modified line 597 of T1n.cpp to Power Off a RGB Led Strip when it's in 
GoodNight Mode.

else if(memory_map[MaCaco_OUT_s + slot] == Souliss_T1n_OnCoil || 
memory_map[MaCaco_OUT_s + slot] == Souliss_T1n_GoodNight)

When reviewing my code changes, please focus on:

After the review, I'll merge this branch into:
/trunk

Original issue reported on code.google.com by JuanPin...@gmail.com on 10 Jan 2015 at 2:25

GoogleCodeExporter commented 9 years ago 
Please refer your change to the latest commit in master branch, I cannot 
identify line 597 as reported.

Original comment by dario.di...@souliss.net on 11 Jan 2015 at 2:19

GoogleCodeExporter commented 9 years ago 
I added a comment on line 597 of T1n.cpp I just added on the if:

|| memory_map[MaCaco_OUT_s + slot] == Souliss_T1n_GoodNight

Original comment by JuanPin...@gmail.com on 11 Jan 2015 at 4:46

GoogleCodeExporter commented 9 years ago 
I cannot identify where the modification has been applied, probably your 
T1n.cpp file isn't the latest one available.

Please identify the required modification in the file available in the last 
commit.

Original comment by dario.di...@souliss.net on 14 Jan 2015 at 2:09

GoogleCodeExporter commented 9 years ago 
Here is the file, I added a comment on it:
https://code.google.com/p/souliss/source/browse/Souliss/base/T1n.cpp

Ty for your patience Dario ;)

Original comment by JuanPin...@gmail.com on 14 Jan 2015 at 3:07

GoogleCodeExporter commented 9 years ago 
You should submit the comment to have it visible to others, as is now I cannot 
see it.

Original comment by dario.di...@souliss.net on 14 Jan 2015 at 4:39

GoogleCodeExporter commented 9 years ago 
Sorry, I learning now how to submit changes to the code.... xDD

Now you can see?

Regards

Original comment by JuanPin...@gmail.com on 14 Jan 2015 at 5:05

GoogleCodeExporter commented 9 years ago 
Changes are in the master branch and will be available in the next release

Original comment by dario.di...@souliss.net on 14 Jan 2015 at 5:07

GoogleCodeExporter commented 9 years ago 
Added on T19 too

Regards

Original comment by JuanPin...@gmail.com on 14 Jan 2015 at 5:26