wisskar / souliss

Automatically exported from code.google.com/p/souliss
0 stars 0 forks source link

Souliss App does not convert lux reading correctly. #81

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago
The T54 typical has a range of 0-40 klux, but the Souliss App converts it wrong 
in some way.
I expect to see 2990 lux when the T54 has a value of 2.99 

Original issue reported on code.google.com by kim.moel...@gmail.com on 22 Aug 2014 at 4:40

GoogleCodeExporter commented 9 years ago
Should have been fixed in 1.3.1, but not sure of it :/

Original comment by shineangelic on 26 Nov 2014 at 1:05

GoogleCodeExporter commented 9 years ago
Issue 82 has been merged into this issue.

Original comment by shineangelic on 26 Nov 2014 at 1:08

GoogleCodeExporter commented 9 years ago
[deleted comment]
GoogleCodeExporter commented 9 years ago
Hi!, I tested this and T54 and T58 fails on the readings, but if I change to 
T51 the values are Ok.

I think the problem is in the lines 67 of 
cmd.setText(Html.fromHtml("Reading: " + (getTypicalDTO().getOutput()*3) + " 
hPa"));
https://code.google.com/p/souliss/source/browse/SoulissClient/src/it/angelic/sou
lissclient/model/typicals/SoulissTypical58PressureSensor.java?repo=soulissapp

cmd.setText(Html.fromHtml("Reading: " + (getTypicalDTO().getOutput()*3) + " 
Lux"));
https://code.google.com/p/souliss/source/browse/SoulissClient/src/it/angelic/sou
lissclient/model/typicals/SoulissTypical54LuxSensor.java?repo=soulissapp

On a T51 is like line 84:
cmd.setText(Html.fromHtml("Reading: " + getOutputFloat() ));
on
https://code.google.com/p/souliss/source/browse/SoulissClient/src/it/angelic/sou
lissclient/model/typicals/SoulissTypical51AnalogueSensor.java?repo=soulissapp

Original comment by JuanPin...@gmail.com on 28 Nov 2014 at 11:11

GoogleCodeExporter commented 9 years ago
you're totally right Juan, I shall fix it on 1.3.2

Original comment by shineangelic on 30 Nov 2014 at 2:21

GoogleCodeExporter commented 9 years ago
I had a deeper look in the code, and it's not that simple. In published version 
1.3.1, T54 should work. Please look at the updated code (I didn't push it yet) 
as now T54 has the same implementation of T51.

T58 is broken for sure, don't use it.

Original comment by shineangelic on 30 Nov 2014 at 2:32

GoogleCodeExporter commented 9 years ago

Original comment by dario.di...@souliss.net on 14 Dec 2014 at 12:51