fix for univ. analytics

wistia / fresh-url

Drop this script on your page and enjoy the freshest of URLs

270 stars 30 forks source link

fix for univ. analytics #3

Closed timse closed 10 years ago

timse commented 10 years ago

its insecure to access univ. analytics via window.ga. The namespace can be defined by specifying a string as the last parameter see: https://developers.google.com/analytics/devguides/collection/analyticsjs/advanced

Therefore it should be accessed via window[window.GoogleAnalyticsObject]

bschwartz commented 10 years ago

Hi there, thanks for pointing this out and for the PR. Everything looks good except for the one line I commented on. Mind changing that and then I'll merge? Thanks!

timse commented 10 years ago

sure thing. my bad :)

bschwartz commented 10 years ago

Haha, no worries. Thanks for spotting this issue in general. I didn't realize people could rename that window.ga variable like that.

timse commented 10 years ago

now with a fresh dist ;)

bschwartz commented 10 years ago

Nice! Thanks for this! :rocket: