Simple TLSv1, take 2

[freerobby]

This builds on @alieander's work in https://github.com/wistia/nsq-ruby/pull/25, adding some specs and building toward the interface we agreed on at the end of that PR. Please continue discussion in this PR; I will close the other one.

[ghost]

@freerobby, thanks for your PR! By analyzing the annotation information on this pull request, we identified @alieander, @bschwartz and @mmoutenot to be potential reviewers

[bschwartz]

Given that this is a breaking change from the current version (in that folks who have code that sets ssl_context will no longer connect via TLS, since tls_v1 defaults to false), should we also change ssl_context to be called tls_options to make it more consistent with other client libraries?

Also, mind adding the start of a CHANGELOG? Figure that will be helpful for folks who will upgrade.

[mschneider82]

I would keep the ssl_context value to make sure the warn is triggered if there is a existing client certificate validation configuration. The boolean tls_v1 matches the nsq tcp specs

[freerobby]

@bschwartz I created a changelog and renamed ssl_context to tls_options.

@mschneider82 We borrowed the tls_options name from pynsq. But to mitigate the point you rase, I do look for ssl_context and use it if tls_options is not provided, so this should catch both cases. Applicable tests are also now run against both usages.

Thanks everyone! I realize this ballooned a bit but think we got it to a good place. Let me know if you have any more suggestions, else I'll merge and release tomorrow.

[alieander]

Looks great! Thanks for taking the time to sort everything out!

[bschwartz]

@freerobby Nice! Just left some comments on the README. Code looks great. Thanks for sorting all this out -- I think it all makes way more sense and the naming is good.

[freerobby]

@bschwartz Thanks, agree with all your comments, just pushed changes accordingly.

[bschwartz]

Nice! 🚀!

[freerobby]

Merged and released. Thank you @alieander for adding this!