search

wistia / nsq-ruby

NSQ Ruby client
MIT License
68 stars 27 forks source link

fixes #27 #28

Closed mschneider82 closed 8 years ago

mschneider82 commented 8 years ago

without urlencode

ghost commented 8 years ago

@mschneider82, thanks for your PR! By analyzing the annotation information on this pull request, we identified @mmoutenot, @bschwartz and @freerobby to be potential reviewers

mrshll commented 8 years ago

wow throwback

mschneider82 commented 8 years ago

i think there are more elegant ways to solve this issue, i am not a ruby expert. this pull req is just a proposal which solves the problem without some 3rd party libs.

a better solution is welcome.

bschwartz commented 8 years ago

@mschneider82 Thanks for this PR! Looks great. I've got a local branch going with this change as well as a test to make sure it's working and that we don't accidentally break it in the future. I'll try to get it up and merged later today or this weekend! Thanks for finding and fixing this!

freerobby commented 8 years ago

This looks right to me.

@bschwartz Are you thinking mainly of testing topic examples? If so, maybe add an ephemeral topic test case to discovery_spec.rb?

bschwartz commented 8 years ago

@freerobby Yeah, that's what I was planning to do.