wistia / nsq-ruby

NSQ Ruby client
MIT License
68 stars 27 forks source link

File.read over File.open for SSLContext #31

Closed alieander closed 7 years ago

alieander commented 7 years ago

All of these Context certs expect a string. File.open responds to .to_s so this has worked fine until now... However it was then never cleaning up the open File until garbage collection. This change will read the file right into a string and close the file straight away being a bit more resource friendly over time.

ghost commented 7 years ago

@alieander, thanks for your PR! By analyzing the annotation information on this pull request, we identified @freerobby, @bschwartz and @Soulou to be potential reviewers

bschwartz commented 7 years ago

Good 👁 @alieander! Going to bump patch versions and push this up.

alieander commented 7 years ago

: smiles: