Close sockets when closing the connection

wistia / nsq-ruby

NSQ Ruby client

MIT License

68 stars 27 forks source link

Close sockets when closing the connection #36

Closed leklund closed 7 years ago

leklund commented 7 years ago

Without calling @socket.close, the sockets will be left open when close_connection is called.

This PR fixes an issue described in #34

Changes:

call @socket.close when closing the connection just before setting it to nil
set sync_close to true when upgrading to an SSL connection so that the underlying TCP connection is closed at the same time.

ghost commented 7 years ago

@leklund, thanks for your PR! By analyzing the annotation information on this pull request, we identified @bschwartz, @freerobby and @alieander to be potential reviewers

bschwartz commented 7 years ago

@leklund Thanks for this! Sorry for taking more than a week to review this. Looks great to me and specs are passing. Going to merge and bump patch versions.

leklund commented 7 years ago

Thanks @bschwartz! No worries about the delay. Happy Holidays! ☃️