wistia / nsq-ruby

NSQ Ruby client
MIT License
68 stars 27 forks source link

Add support for max_attempts #43

Closed leklund closed 6 years ago

leklund commented 6 years ago

Add a new option to the Consumer for max_attempts. The Consumer passes the option to the connection. In the read_loop we check for max_attempts and finish messages that have been attempted the maximum number of times.

leklund commented 6 years ago

@bschwartz pinging you for visibility. Thanks!

bschwartz commented 6 years ago

@leklund Oops, sorry I missed this before! Change looks good to me. I'll take a closer look tonight and get it merged in.

bschwartz commented 6 years ago

@leklund Going to bump a minor version and release shortly. Thanks for this, Lukas!

bschwartz commented 6 years ago

https://rubygems.org/gems/nsq-ruby/versions/2.3.0