search

wistia / nsq-ruby

NSQ Ruby client
MIT License
68 stars 27 forks source link

use URI.encode_www_form_component instead of URI.escape #65

Closed leklund closed 10 months ago

leklund commented 2 years ago

URI.escape has been deprecated and obsolete for many years. Ruby 2.7 emits a warning:

nsq-ruby-2.3.1/lib/nsq/discovery.rb:73: warning: URI.escape is obsolete

Using URI.encode_www_form_component will properly encode the topic for the lookup query.

annawinkler commented 2 years ago

I would love to see this merged and a new release pushed! The warnings in the console are super annoying.