search

wit-ai / wit-go

Go client for wit.ai HTTP API
MIT License
156 stars 30 forks source link

Add missing app fields #11

Closed thibaultleouay closed 5 years ago

thibaultleouay commented 5 years ago

Add missing fields from app https://wit.ai/docs/http/20170307#get__apps__app_id_link

thibaultleouay commented 5 years ago

I had to create a custom type for the time as the time sent by the wit.ai api is not in the rfc3339 format.

plutov commented 5 years ago

Nice, thank you for working on this! Please check the integration tests, they failed on Travis CI.

thibaultleouay commented 5 years ago

The integration test TestIntegrationSamples also fail on master

plutov commented 5 years ago

@thibaultleouay master looks green - https://travis-ci.org/wit-ai/wit-go/branches. Have you tried it locally, you need to set WITAI_INTEGRATION_TOKEN locally.

thibaultleouay commented 5 years ago

Locally with my WITAI_INTEGRATION_TOKEN it works. Also on master I dont know how they passed.

The sample test makes this request when you dont set any SampleEntity curl -XPOST 'https://api.wit.ai/samples?v=20170307' \ -H "Authorization: Bearer $YOUR_TOKEN" \ -H "Content-Type: application/json" \ -d '[{ "text": "I live in London", "entities": null }]'

plutov commented 5 years ago

Agree, locally it works well, I am merging this PR, and will investigate the tests after.