iOS SDK Improvements - Githubissues

wit-ai / wit-ios

Wit.ai iOS client

Other

222 stars 71 forks source link

iOS SDK Improvements #1

Closed hactar closed 10 years ago

hactar commented 10 years ago

I've updated the iOS SDK to use AFNetworking 2.X. This allows us to use WIT with modern apps that use the new version of the framework. It means dropping iOS 5 support, but even Apple doesn't include that in Xcode these days.

I've also made a few tweaks to how the recorder behaves (super short recordings are not uploaded, failedRecording sound can be played if recording fails or is too short). The recorder also uses didFinishPlaying to unlock noise state, because using a GCD timer based solution could become out of sync on heavy device load.

A few 64 bit compiler warnings have also been squelched.

blandinw commented 10 years ago

Hey @hactar,

Thanks for your contribution, this looks great!

I have 2 issues with this PR though:

I don't think we should exclude the Podfile.lock from the repo. https://github.com/thoughtbot/liftoff/issues/30.
The code doesn't use the minimal duration variable in the condition, but the .5 magic number directly. Probably a small oversight here :)

hactar commented 10 years ago

Oops, yes, the minimal duration thing, stupid mistake :) As for the lock file, well there's quite a lot of discussion on the web about this: http://stackoverflow.com/questions/9446644/what-goes-into-your-gitignore-if-youre-using-cocoapods

I personally don't include the lock file in my things because the truth is many frameworks are less than well maintained and the first thing you have to do is run pod update anyway, unless you want to use things that are X years old... But its your framework, if you guys want to keep it in then I'll kick it out of the ignore file.

blandinw commented 10 years ago

Regarding the Podfile.lock, we'd rather keep it checked in. The post I linked to is from @irrationalfab, from the CocoaPods team, so I guess he knows better than anyone ^~^

Thanks again for your contribution, I was actually working on an update to use the latest Wit API that will allow streaming voice instead of batch upload... In other words, it should greatly reduce response times :)

I'll merge-squash this right now.

Stay tuned!

hactar commented 10 years ago

Good luck, can't wait to see the streaming update!

blandinw commented 10 years ago

@hactar I'll close this PR.

I merged your changes (squashed) and finished working on the streaming API. The SDK changed quite a bit, I think it's way better and leaner now.

Waiting for your feedback on the streaming API :)

Thanks again for the contrib!