search

wit-ai / wit-ios

Wit.ai iOS client
Other
222 stars 71 forks source link

VAD Speech Detection Scope, Callback #56

Closed dsposito closed 8 years ago

dsposito commented 8 years ago

Changing the scope of the recordingSession property to public allows access to the following property: [Wit sharedInstance].recordingSession.recorder.stoppedUsingVad

This is useful for playing a confirmation sound effect after voice capture is stopped so the user knows his/her voice command was received.

The new delegate methods allow for triggering actions when a user begins speaking a voice command. This is useful when toggleCaptureVoiceIntent is manually triggered to start listening and you want to perform an action if and when the user begins speaking a voice command.

thediary commented 8 years ago

Public access to .recordingSession is important for #57 and for confirmation sound effects, and a whole lot of other uses. We're considering using the plain API now in our app just since then we have control over all of these parts of the app.

Everything looks good in this PR and I'd highly suggest it get merged!

dsposito commented 8 years ago

@l5t @blandinw Thoughts on this PR?

@thediary Hopefully this can get merged soon. In the meantime, you can fork this repo and update your Podfile to install from a specific repo/branch like so (I recommend you create your own fork rather than directly reference my branch):

pod 'Wit', :git => 'https://github.com/dsposito/wit-ios-sdk.git', :branch => 'feature/vadSpeechDetectionCallback'

blandinw commented 8 years ago

Hey guys, sorry for the lack of response. That looks good and we're happy to merge :)

@thediary Feel free to fork/use other APIs, but just know that we're open to PRs! There's a lot of subtle bugs with audio recording / streaming and we provide a SDK so everyone can benefit from anyone's experience. We will be more responsive in the future.

thediary commented 8 years ago

Thanks @blandinw! any way this can make it into a cocoa pods version? If not that's no biggie, but it would be a nice to have ; ) If we come across further potential improvements, we'll be sure to contribute! Thanks for the response and the help!