witalihirsch / Mono-gtk-theme

Mono Theme for Gnome
GNU General Public License v3.0
362 stars 21 forks source link

Some issues and ideas on GNOME 43 #11

Open XMelph opened 2 years ago

XMelph commented 2 years ago

I'd like to begin by extending a heartfelt thank you for crafting such a delightfully simple and modern theme. Your work has undeniably left a positive impression, and I'm truly grateful for that. I've been enjoying it for a few months now, this theme strikes a remarkable balance between simplicity and elegance. Its clean, stylish, and attention-grabbing design is nothing short of remarkable. I genuinely believe that this theme would make an excellent default choice for GNOME. Its accessibility makes it suitable for all, while its modern design would surely resonate with a wide range of users. On top of that, I've got a couple of ideas for potential improvements that I'd love to share.

I think the pop-up buttons would look great in red and blue, similar to the colors used in Notepad. I think this would add a bit of extra visual interest and make the buttons stand out more. OBS: By the way, the colors of the buttons have disappeared as you can see in the third image. Captura de tela de 2023-01-15 22-00-43 Captura de tela de 2023-01-15 22-01-11 Captura de tela de 2023-08-25 13-29-40

I think that the Gnome Software app should remain largely unchanged from the default version. This would allow it to retain its clean, modern look and feel. Captura de tela de 2023-08-25 13-30-02

The Fluent theme includes a line that is used to highlight selections in applications. I believe that this is a useful and aesthetically pleasing feature that could be implemented in other themes as well. https://www.gnome-look.org/s/Gnome/p/1574551 Captura de tela de 2023-08-23 14-48-41

Hello @witalihirsch ! I trust you're doing well. I know I haven't been as active lately, but I wanted to take a moment to thank you again for your amazing work on the theme. It's truly a stunning and contemporary overhaul of the standard Adwaita, and I'm genuinely thankful for your effort in bringing it to life. Using it over the past few months has been an absolute pleasure – I'm still smitten. It's given my desktop a whole new lease on life.

Once again, a big hats-off for your dedication! Discovering your theme has been a real gem. And to those reading this, I urge you to give this thread a nudge so that more folks can bask in its brilliance! Linux4ever!

witalihirsch commented 2 years ago

thanks for the feedback :) the 1st and 3rd have been fixed in the latest release, i'll think about the dock, how to do it more delicately and so that the text can be seen. for Firefox i'll make a separate theme later about Aylur's Widgets, i didn't find quick toggles there, is that the same extension? image

XMelph commented 2 years ago

In Gnome 42 Quick Settings has to be installed separately Here is the link: https://github.com/Aylur/dotfiles/tree/gnome42

XMelph commented 2 years ago

I am very proud to have someone of your talent in our community. A great week to you, friend!

witalihirsch commented 2 years ago

I am very proud to have someone of your talent in our community. A great week to you, friend!

that nice to hear :)

witalihirsch commented 2 years ago

sound/brightness osd you can put on the panel with better osd or i didn't realize what edges you said

witalihirsch commented 2 years ago

В Gnome 42 Быстрые настройки должны быть установлены отдельно Вот ссылка: https://github.com/Aylur/dotfiles/tree/gnome42

i tried install, but extension is outdated, in metadata texted this for 43

XMelph commented 1 year ago

В Gnome 42 Быстрые настройки должны быть установлены отдельно Вот ссылка: https://github.com/Aylur/dotfiles/tree/gnome42

i tried install, but extension is outdated, in metadata texted this for 43

This is pretty weird, I even installed the extension and it worked fine. What version of Gnome are you currently on? If it's 43 - https://github.com/Aylur/dotfiles/tree/main If it's 42 - https://github.com/Aylur/dotfiles/tree/gnome42

witalihirsch commented 1 year ago

about sound / brightness osd, it should be located on the top panel using the better osd extension image image i created a new repository with a firefox theme, you can test it :) Installation: Go to about:support in Firefox. Application Basics > Profile Directory > Open Directory. Go to chrome folder in directory, remove all files or move them and paste mono-firefox-theme, userChrome.css, userContent.css

osieltorres commented 1 year ago

@witalihirsch it should not be mandatory to use better-osd for sound/brightness to look OK. Currently if you set some light background wallpaper for instance, the controls are just invisible to user. Instead of adding any other extension/tool, my thought is that(controls) should have some shadow in the background, to precisely avoid this kind of issue without requiring additional tools/extensions. See following screenshot image

witalihirsch commented 1 year ago
witalihirsch commented 1 year ago

about aylur's widgets, on gnome 43 everything works correctly and there is an accent color image

XMelph commented 1 year ago

Again, thank you very much for the theme. It keeps getting better and better with each update!

osieltorres commented 1 year ago

I have seen this issue while enabling/disabling the WIFI on my laptop, the proper icon has no padding from the container. Perhaps is not an issue itself as you can live with it, but from design perspective, it is different from default(i.e.: the volume or brightness control icons) See below screenshots (WiFi vs the Volume controls): image image

witalihirsch commented 1 year ago

I have seen this issue while enabling/disabling the WIFI on my laptop, the proper icon has no padding from the container. Perhaps is not an issue itself as you can live with it, but from design perspective, it is different from default(i.e.: the volume or brightness control icons) See below screenshots (WiFi vs the Volume controls): image image

fixed

osieltorres commented 1 year ago

The padding is fixed but I think UI should be more like this (with airplane icon): image

rather than actual: image

XMelph commented 1 year ago

Captura de tela de 2022-12-14 09-31-38 Captura de tela de 2022-12-14 09-46-16

There is an "icon" missing in nautilus (This is caused by the theme and not the icon pack)

witalihirsch commented 1 year ago

The padding is fixed but I think UI should be more like this (with airplane icon): image

rather than actual: image

is this some kinda extension to display osd with wifi and airplane?

osieltorres commented 1 year ago

The padding is fixed but I think UI should be more like this (with airplane icon): image rather than actual: image

is this some kinda extension to display osd with wifi and airplane?

No, this is default OSD for COSMIC DE on Pop!_OS

witalihirsch commented 1 year ago

Captura de tela de 2022-12-14 09-31-38 Captura de tela de 2022-12-14 09-46-16

There is an "icon" missing in nautilus (This is caused by the theme and not the icon pack)

fixed, check last commit

XMelph commented 1 year ago

Just a question, is this here on the calendar normal? (the black space when I place my mouse over) Captura de tela de 2022-12-19 07-32-28

witalihirsch commented 1 year ago

Just a question, is this here on the calendar normal? (the black space when I place my mouse over) Captura de tela de 2022-12-19 07-32-28

fixed, check

osieltorres commented 1 year ago

I found out that this bug in top bar notification calendar, when you click on any date of the next month (the ones in lighter font) which cuts the notification area almost to fit the calendar height, missing the events as well as the weather area. Attached screenshots: Before: Screenshot from 2022-12-28 22-57-46 After click on a next month date: Screenshot from 2022-12-28 22-58-16

witalihirsch commented 1 year ago

I found out that this bug in top bar notification calendar, when you click on any date of the next month (the ones in lighter font) which cuts the notification area almost to fit the calendar height, missing the events as well as the weather area. Attached screenshots: Before: Screenshot from 2022-12-28 22-57-46 After click on a next month date: Screenshot from 2022-12-28 22-58-16

I checked with the default adwaita theme for gnome-shell and I think it's a problem with gnome-shell itself

XMelph commented 1 year ago
osieltorres commented 1 year ago

Some issue not commented regarding Chromium based browsers. The issue is present by adding some white line between browser bookmark tab and the content pane of it in dark mode. Screenshot attached Screenshot from 2023-01-23 12-53-17 This line may increase or decrease height and/or width depending on mouse hover and website content reload.

witalihirsch commented 1 year ago

FIRST OF ALL, I'D LIKE TO THANK YOU SO MUCH FOR MAKING A PERFECTLY SIMPLE AND MODERN THEME.

My experience with this theme was phenomenal. I believe this theme should be the default theme for GNOME. Simple, modern, clean and beautiful. Your work was spectacular, congratulations :)

Addition: I think I just have to thank you, I've been using this theme for a few months now and it's been drawing a lot of attention from other people, I've even managed to make other people even want to use Linux. I always warn that it is a theme, but the others remain interested.

Ideas:

- Pop-up buttons:

It's more of an opinion about the buttons, I think they would look better in red and blue colors. Something similar to what appears in notepad.

Captura de tela de 2023-01-15 22-00-43

Captura de tela de 2023-01-15 22-01-11

- Adjust Roundness:

In the "Aylur Widgets" extension there is an option that allows you to adjust the roundness of the button. It would be interesting to keep this idea already coming from the pattern.

P.S: The code image will be in the comments.

Captura de tela de 2023-01-15 22-10-23

Captura de tela de 2023-01-15 22-11-23

- GTK 3:

In some apps the theme acts strangely. The dated problem in this app is found in GTK3 itself.

Application: Krita

Themes: Mono (first image) and Lavanda (second image).

Captura de tela de 2023-01-15 22-23-55

Captura de tela de 2023-01-15 22-23-43

Hey! It's been a long time since I've written anything here, I hope you're well too, Happy New Year to you! I would like to thank you again for the work of creating a theme that is an extremely good rework of the standard Adwaita. I just want to say thank you so much for this beautiful theme. To those reading my comment now, please share this topic so that it gains even more reach! Linux4ever!

I am actually very encouraged by your comments. it inspires and gives hope that I'm doing something useful :) I'll start fixing it soon, but for now I decided to make a preview for the whole project, you can watch it from the link

p.s. maybe a bit late, but Happy New Year to you too! ☺️

witalihirsch commented 1 year ago

Some issue not commented regarding Chromium based browsers. The issue is present by adding some white line between browser bookmark tab and the content pane of it in dark mode. Screenshot attached Screenshot from 2023-01-23 12-53-17 This line may increase or decrease height and/or width depending on mouse hover and website content reload.

fixed

witalihirsch commented 1 year ago

FIRST OF ALL, I'D LIKE TO THANK YOU SO MUCH FOR MAKING A PERFECTLY SIMPLE AND MODERN THEME. My experience with this theme was phenomenal. I believe this theme should be the default theme for GNOME. Simple, modern, clean and beautiful. Your work was spectacular, congratulations :) Addition: I think I just have to thank you, I've been using this theme for a few months now and it's been drawing a lot of attention from other people, I've even managed to make other people even want to use Linux. I always warn that it is a theme, but the others remain interested.

Ideas: - Pop-up buttons: It's more of an opinion about the buttons, I think they would look better in red and blue colors. Something similar to what appears in notepad. Captura de tela de 2023-01-15 22-00-43 Captura de tela de 2023-01-15 22-01-11

- Adjust Roundness: In the "Aylur Widgets" extension there is an option that allows you to adjust the roundness of the button. It would be interesting to keep this idea already coming from the pattern. P.S: The code image will be in the comments. Captura de tela de 2023-01-15 22-10-23 Captura de tela de 2023-01-15 22-11-23

- GTK 3: In some apps the theme acts strangely. The dated problem in this app is found in GTK3 itself. Application: Krita Themes: Mono (first image) and Lavanda (second image). Captura de tela de 2023-01-15 22-23-55 Captura de tela de 2023-01-15 22-23-43

Hey! It's been a long time since I've written anything here, I hope you're well too, Happy New Year to you! I would like to thank you again for the work of creating a theme that is an extremely good rework of the standard Adwaita. I just want to say thank you so much for this beautiful theme. To those reading my comment now, please share this topic so that it gains even more reach! Linux4ever!

  1. new right button image

  2. didn't realized what you mean

  3. fixed titlebar buttons bug image

XMelph commented 1 year ago

My tests ended this week so I'm taking advantage of the free time and trying to "fix" certain bugs in my own way, later I'll update the comment with indications of the problems and possible solutions. I can't believe we're already at GNOME 44, time flies so fast.

witalihirsch commented 1 year ago

My tests ended this week so I'm taking advantage of the free time and trying to "fix" certain bugs in my own way, later I'll update the comment with indications of the problems and possible solutions. I can't believe we're already at GNOME 44, time flies so fast.

These are good news, Gnome 44 hasn't arrived on my Manjaro yet. And I haven't had any time to work on the theme customization lately :(

XMelph commented 1 year ago

Hey! Hope everything is alright, I'm a little tired now, but I managed to finish the file that indicates the problems. Then I'll send the suggestions and try to show them in screenshots tomorrow. Have a good night :) MonoThemeFix.txt