[x] PR message includes a link to the relevant issue(s) 💁♀️🖇️🧾
[x] New features have test coverage 📋☑️☑️☑️
[x] Commit messages are well-formatted
(please follow this guide) 📝📐
[x] The app boots and pronoun pages are served correctly
(try lein ring server) 👩💻🚀
Fixes Issue: #95
Hey!
So I saw that there is another open PR for this issue which looks good, but since it's incomplete I thought I'd have a go. I also noticed that in that solution another .css file is created which contains classes for all the pronouns. This is fine but means having two "sources of truth" so I thought having the color for the pronoun in the table would fix this.
I've set the first three pronouns to have colors and left the rest black, but if you want me to leave them all black for now I can do that. Also I've left the links to the pronouns on the landing page and the 'all' list as their default link colors, but I don't think it would be very difficult to implement it for them too so I can do that in a subsequent PR or whatever.
The app boots fine and all the tests pass, and I've added some tests for the new stuff too.
I really love this project and I hope this is useful!
Thanks!
Also, disclaimer, I'm not very good at Clojure (in fact this is my first time doing anything real with it) so sorry in advance if there's anything I could have done better. I'm super happy to make changes.
lein ring server) 👩💻🚀Fixes Issue: #95
Hey!
So I saw that there is another open PR for this issue which looks good, but since it's incomplete I thought I'd have a go. I also noticed that in that solution another
.cssfile is created which contains classes for all the pronouns. This is fine but means having two "sources of truth" so I thought having the color for the pronoun in the table would fix this.I've set the first three pronouns to have colors and left the rest black, but if you want me to leave them all black for now I can do that. Also I've left the links to the pronouns on the landing page and the 'all' list as their default link colors, but I don't think it would be very difficult to implement it for them too so I can do that in a subsequent PR or whatever.
The app boots fine and all the tests pass, and I've added some tests for the new stuff too.
I really love this project and I hope this is useful!
Thanks!
Also, disclaimer, I'm not very good at Clojure (in fact this is my first time doing anything real with it) so sorry in advance if there's anything I could have done better. I'm super happy to make changes.
Images