with-heart / aoe2-ui

2 stars 0 forks source link

Re-evaluate using `exact` option for optional schema properties #44

Open with-heart opened 8 months ago

with-heart commented 8 months ago

By using exact, we're locking type definitions to property?: Value which means we can't pass undefined as the value. This isn't normally a problem but it becomes one in tests when using effect/schema/Arbitrary because we can't undefine randomly generated values for certain optional properties (like ZPlane or ZPlaneLocalOffset).