search

withanage / ror

GNU General Public License v3.0
8 stars 10 forks source link

View form taster #1

Open ainulrafiq opened 3 years ago

ainulrafiq commented 3 years ago

Dear Withanage, we have tasted the plugin, and here is the result https://myjurnal.poltekkes-kdi.ac.id/index.php/HIJP/article/view/204/version/119 for the affiliation has in the ROR database, and, here https://myjurnal.poltekkes-kdi.ac.id/index.php/HIJP/article/view/200 that the affiliation not in the ROR database.

Thank you!

withanage commented 3 years ago

@ainulrafiq

Thanks a lot for the quick testing. the plugin variable is not yet in the template , you have to patch the ojs 3.2.1 article_details.tpl as here or update the branch , if you have the installation under git. https://github.com/withanage/ror/

Then you will see the ror badge.

About 200, I will create a patch soon.

ainulrafiq commented 3 years ago

@withanage I've tried to patch the article.tpl use the extra code {if $author->getData('rorId')} {$rorIdIcon} {/if} and the ROR link still not transform into a badge .. :-)

withanage commented 3 years ago

@ainulrafiq 200 should be fixed with the latest commit now.

With Badge, we have to test may be together, cause actually I could not reproduce it.

Will you be able to have a very short online call ?

ainulrafiq commented 3 years ago

Dear @withnage,Let do it by Google Meet, here is my email.If you have a time, I will be able to meet at 09.00 am WITA.Thank you!Pada tanggal 1 Des 2020 05:06, Dulip Withanage notifications@github.com menulis: @ainulrafiq 200 should be fixed with the latest commit now. With Badge, we have to test may be together, cause actually I could not reproduce it. Will you be able to have a very short online call ?

—You are receiving this because you were mentioned.Reply to this email directly, view it on GitHub, or unsubscribe.

withanage commented 3 years ago

Dear @ainulrafiq Thanks, I have written you an email and taken your email out of the comment for privacy.

withanage commented 3 years ago

Dear @ainulrafiq could you test this version ? https://github.com/withanage/ror/releases/tag/v1_0_0-1

ainulrafiq commented 3 years ago

Dear @withanage , I just try out the new one above and the ROR badge appears. https://myjurnal.poltekkes-kdi.ac.id/index.php/HIJP/article/view/204

but, there is color changes on the ORCID iD badge ..

withanage commented 3 years ago

Dear @ainulrafiq thanks, this patch should fix that. https://github.com/withanage/ror/releases/tag/v1_0_0-5 Please delete template cache too.

ainulrafiq commented 3 years ago

Dear @withanage , I have applied the patch you mentioned above but there are no chances for the ORCID iD badge's color .. thanks

withanage commented 3 years ago

Dear @ainulrafiq ,

That was a very good one, you found. Thanks !

could you plelase try this version ?

https://github.com/withanage/ror/releases/tag/v1_0_0-6

You may have to delete the template cache and also the cache in your browser.

ainulrafiq commented 3 years ago

Dear @withanage , I pleased to inform you that the last version does not change the ORCID iD badge color. https://myjurnal.poltekkes-kdi.ac.id/index.php/HIJP/article/view/204

Thank you!