Moved chooseElevator from ElevatorSubsystem to Scheduler

withaspirit / Elevator-Simulation

Elevator System Simulation project

1 stars 1 forks source link

Moved chooseElevator from ElevatorSubsystem to Scheduler #155

Closed ryandash closed 2 years ago

ryandash commented 2 years ago

moved chooseElevator() method from ElevatorSubsystem to Scheduler
refactor code in IntermediateHost to make it easier to understand and allow Scheduler to process objects
added methods to add ElevatorMonitors and respond to system events
removed method processPacketObject() and moved code to the scheduler in order to access objects in the scheduler

withaspirit commented 2 years ago

LMK if it still works; there should be 12 "moved" statements

ryandash commented 2 years ago

LMK if it still works; there should be 12 "moved" statements

withaspirit commented 2 years ago

I noticed that ElevatorSelectionTest failed. Maybe it's cause it doesn't have the list of elevators?

withaspirit commented 2 years ago

Running Structure works fine. Not sure about running the 3 mains at once.

ryandash commented 2 years ago

I noticed that ElevatorSelectionTest failed. Maybe it's cause it doesn't have the list of elevators?

I will take a look at this later today.

ryandash commented 2 years ago

Running Structure works fine. Not sure about running the 3 mains at once.

Intelliji does not allow starting main methods in a specific order which means that the subsystems could send a message before the scheduler is available causing the subsystem to softlock waiting for a reply that it will never get. The only way to test the 3 main methods is in eclipse or with a plugjn in inteliji to start the main methods in order.

ryandash commented 2 years ago

The 3 main methods should be runnable at once with the Multirun plugin in IntelliJ

withaspirit commented 2 years ago

The order in which the mains should be run to get the system working should be included in the PR description. Stuff like that is important. In Eclipse, I found out by trial-and-error that both ElevatorSubsystem and Scheduler must be run before FloorSubsystem.

I'm not sure how the Multirun plugin in IntelliJ is supposed to work. I installed it but the run configuration doesn't work for me.

withaspirit commented 2 years ago

If this is the PR that gets the 3 main methods working together, that should be noted in the PR notes + change list

ryandash commented 2 years ago

The order in which the mains should be run to get the system working should be included in the PR description. Stuff like that is important. In Eclipse, I found out by trial-and-error that both ElevatorSubsystem and Scheduler must be run before FloorSubsystem.

I'm not sure how the Multirun plugin in IntelliJ is supposed to work. I installed it but the run configuration doesn't work for me.

I have added some notes in my description at the top of my branch for steps that I have done to make the run configuration work.