Fixing ArrivalSensor testing in FloorSubsystem:

Bnortron commented 2 years ago

Recent Changes:

All Tests Pass:

Modified FloorSubsystem to add ServiceRequests to the proper floors and to process ApproachRequests
Modified Floor class to keep track of ServiceRequests in its ArrivalSensor
isElevatorExpected() method in Floor class is used by FloorSubsystem to modify an ApproachRequest if an elevator should stop
Added documentation to ArrivalSensorTest class
Modified setUp() in ArrivalSensorTest
Added testGetSpecificFloor() and testAddServiceRequestToFloor() tests to FloorSubsystemTest class
Modified testApproachingDestination() and testNotApproachingDestination() tests in FloorSubsystemTest
Removed testApproachEventNotChanged() and testApproachEventChanged() tests from FloorTest class
Added testAddRequestToSensor() and testIsElevatorExpected() tests to FloorTest

Signed-off-by: Brady Norton bnort.11@gmail.com

withaspirit commented 2 years ago

Will you be doing more tests in the test classes?

withaspirit commented 2 years ago

I'm not sure if it was doing that before though

Bnortron commented 2 years ago

Do you mean the actual ApproachEvent from the elevator that's being sent when the system is running?

withaspirit commented 2 years ago

Do you mean the actual ApproachEvent from the elevator that's being sent when the system is running?

Yeah. Only reason for failure I can think of immediately is an equality check fail between a ServiceRequest and an ApproachEvent. Their time values, direction, elevatorNumber, and floorNumber should be the same.

withaspirit commented 2 years ago

The addition of the ArrivalSensorTest and the FloorTest and FloorSubsystem test should be noted in the README, you can do that in #205

withaspirit / Elevator-Simulation

Fixing ArrivalSensor testing in FloorSubsystem: #208