Change Time methods - Githubissues

withaspirit / Elevator-Simulation

Elevator System Simulation project

1 stars 1 forks source link

Change Time methods #226

Closed ryandash closed 2 years ago

ryandash commented 2 years ago

changed time methods in RequestQueue to use travelTime and doorTime

withaspirit commented 2 years ago

Looks good so far

withaspirit commented 2 years ago

Looks good otherwise.

withaspirit commented 2 years ago

Do you think it would be a good idea to remove the unused methods at the end of the Elevator file?

ryandash commented 2 years ago

Do you think it would be a good idea to remove the unused methods at the end of the Elevator file?

They should probably be removed before we make our final jar file. Extra methods that are doing nothing in an already large class only make it harder to read.