withastro / action

A GitHub Action that deploys your Astro project to GitHub Pages
Other
143 stars 31 forks source link

Setup Node step failing when in subfolder #20

Closed omar-h-omar closed 1 year ago

omar-h-omar commented 1 year ago

Hi there I noticed that the Setup Node step is missing cache-dependency-path. Without this, if the user provides a path to a subfolder the build will fail as node won't be able to find the lockfiles since they are in the subfolder. Here's a picture of a build failing because of this issue:

Screenshot 2023-01-26 at 11 32 58 am
spencerrais commented 1 year ago

I am also running into the same issue.

natemoo-re commented 1 year ago

This should be fixed in the latest (v0.2.0)

rajat1saxena commented 1 year ago

This caused #21 for me. Anyway to disable it?