withastro / action

A GitHub Action that deploys your Astro project to GitHub Pages
Other
153 stars 34 forks source link

Support `node-version-file` options of `actions/setup-node@v4` #47

Open NozomuIkuta opened 6 months ago

NozomuIkuta commented 6 months ago

Currently, available options of withastro/action@v2 is a subset of those of actions/setup-node@v4. For example, node-version-file is not available.

In my usecase, I define Node.js as engines.node in package.json. If I use actions/setup-node@v4 directly, I can specify node-version-file so that it reads the property. Without this option, I have to manually sync Node.js versions in 2 files, workflow YAML file and package.json.

By the way, pnpm/action-setup@v3 automatically detects package manager and its version based on packageManager property in package.json, if package-manager of withastro/action@v2 is not specified, which enables me to manage package manager version in one place.

It may be fine to support other options of actions/setup-node@v4 too.