search

withastro / action

A GitHub Action that deploys your Astro project to GitHub Pages
Other
153 stars 34 forks source link

feat: add `node-version-file` option #48

Closed NozomuIkuta closed 4 months ago

NozomuIkuta commented 6 months ago

Resolves #47 This PR includes trailing spaces removal on save.

⚠️ This is my very first PR to this repository, so I might be missing something important.

natemoo-re commented 4 months ago

I see where this is coming from, but we shouldn't expose every option from sub-actions. That would become very unruly, and the goal here is to have a small number of inputs to provide quick onboarding for the majority of simple use cases.

If you have a more complex setup that this action supports, we recommend writing your own custom GitHub Action.

devmattrick commented 4 months ago

@natemoo-re I understand your concern about not wanting to expose every possible option, but imo it's a pretty common pattern to have a file define the Node version that a project uses. A lot of Node tooling is built around this sort of thing. I may be being reductive here, but I feel like supporting this option wouldn't necessarily open up a can of worms that would drastically increase complexity.