withastro / action

A GitHub Action that deploys your Astro project to GitHub Pages
Other
143 stars 31 forks source link

add optional build output directory #51

Closed wassfila closed 1 month ago

wassfila commented 2 months ago

This is a suggestion to enable the inputs.out definition as this action currently does not allow usage of the astro config outDir. If outDir is different than './dist' then users can specify it in the out input. I was hesitant to call it differently like outDir our out-dir to avoid any naming case convention conflict. The only catch is that if path is specified, then out must necessarily also be specified, which is mentioned in the description

natemoo-re commented 1 month ago

I'm fairly certain that this would be covered by https://github.com/withastro/action/pull/29, but I'm not sure when I might get a chance to finish that PR up.

Ideally, this action would be able to inherit the outDir option from the Astro config. I'm going to close this to avoid adding a new option to the current action, but this is definitely a very real pain point that should be fixed.