fix(cloudflare): _routes.json deduplication

[alexanderniebuhr]

Changes

• this should fix the deduplication error we had for more complex route definitions
• this is a fix for v9 of the adapter, in v10 we will refactor the complete route generation logic (so this has a limited time to live)
• also reverting change in test file https://github.com/withastro/adapters/pull/137/files#diff-d3130bfe10263d21a437f7e826fc4594ffc77e5cc37be1b09b10f5553b08c3ed
• closes https://github.com/withastro/adapters/issues/149

Testing

• I personally don't think it is worth to add a complete fixture for such edge-case, however we can if anyone has strong opinions
• Let's investigate if we can add unit tests instead which test only util functions

[changeset-bot[bot]]

🦋 Changeset detected

Latest commit: 88a1f494ae4128c023298d495b2e2fd5677ab725

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 15 packages

| Name | Type | | ---------------------------------------------- | ----- | | @astrojs/cloudflare | Patch | | @test/astro-cloudflare-dev-runtime-pages | Patch | | @test/astro-cloudflare-dev-runtime-workers | Patch | | @test/astro-cloudflare-directory-mode | Patch | | @test/astro-cloudflare-external-image-service | Patch | | @test/astro-cloudflare-function-per-route | Patch | | @test/astro-cloudflare-hybrid | Patch | | @test/astro-cloudflare-no-output | Patch | | @test/astro-cloudflare-prerender | Patch | | @test/astro-cloudflare-routes-json | Patch | | @test/astro-cloudflare-wasm-function-per-route | Patch | | @test/astro-cloudflare-wasm-directory | Patch | | @test/astro-cloudflare-wasm | Patch | | @test/astro-cloudflare-with-solid-js | Patch | | @test/astro-cloudflare-wrangler-runtime | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[alexanderniebuhr]

Current dependencies on/for this PR:

• #171 👈
• main

This stack of pull requests is managed by Graphite.

[MehrdadKhnzd]

Hi! It still doesn't work, I still get the error I used to get: Error: Failed to publish your Function. Got error: Error 8000057: Overlapping rules in _routes.json are not allowed.

[alexanderniebuhr]

@MehrdadKhnzd can you please submit a minimal reproduction in a new issue?

[MehrdadKhnzd]

@alexanderniebuhr The problem is that I couldn't. I tried to reproduce it two times, but I wasn't successful when I partially recreated some of the conflicting structures of my project. I even thought it might be due to some other added plugins, but that wasn't the case. I might give it another try with a complete replication of my file structure to see how it goes, but it will be really time-consuming. Do you know when v10 is going to be ready?