fix(cloudflare): uses default values for noExternal on client

[alexanderniebuhr]

Changes

• save the default values of noExternal and reapply them for client

Testing

• existing tests

Docs

• bug fix, no docs needed

[changeset-bot[bot]]

🦋 Changeset detected

Latest commit: 21e3d0faa3111190430940f55c69c6c7bb587f14

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 8 packages

| Name | Type | | ------------------------------------------------ | ----- | | @astrojs/cloudflare | Patch | | @test/astro-cloudflare-astro-dev-platform | Patch | | @test/astro-cloudflare-external-image-service | Patch | | @test/astro-cloudflare-no-output | Patch | | @test/astro-cloudflare-routes-json | Patch | | @test/astro-cloudflare-wasm | Patch | | @test/astro-cloudflare-with-solid-js | Patch | | @test/astro-cloudflare-wrangler-preview-platform | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[bluwy]

Is there a repro/example that shows this fix is required? I don't think the ssr.* config should have affected the client build since it's not related to SSR/server build 🤔

[alexanderniebuhr]

You're right this is probably not required, but wouldn't it be safe to set it back to the initial value anyways?

[bluwy]

I don't think it's needed. If the build chain at one point needs to set noExternal: true, then the rest should keep it the way it is.