search

withastro / astro.build

https://astro.build
335 stars 131 forks source link

feat: enable ISR #1067

Open ElianCodes opened 1 month ago

vercel[bot] commented 1 month ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
astro-build ✅ Ready (Inspect) Visit Preview Apr 12, 2024 2:51pm
ElianCodes commented 1 month ago

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @ElianCodes and the rest of your teammates on Graphite Graphite

lilnasy commented 1 month ago

ISR cache wouldn't look at search params, so https://github.com/withastro/astro.build/blob/main/src/pages/integrations/%5B...page%5D.astro (as one example) wouldn't work out of the box.

natemoo-re commented 1 month ago

@lilnasy in that case, what would you recommend using here? A cdn-cache-control header?

lilnasy commented 1 month ago

Yeah, standard cache control would be my first attempt before vendor-specific ISR.

ISR gives you persistent and global cache. We could see if the header's ephemeral and per-region cache works for us first.