search

withastro / astro

The web framework for content-driven websites. ⭐️ Star to support our work!
https://astro.build
Other
43.87k stars 2.29k forks source link

bug: removes type override from defineAction #11292

Closed jdtjenkins closed 1 week ago

jdtjenkins commented 1 week ago

Changes

This PR removes the type override for the accept parameter in the defineAction Actions function.

Fernando Herrera pointed out earlier that the accept param for defineAction only suggested json in the intellisense instead of both json and form.

Now I'm not going to pretend I understand everything going on in the typing for the accept param here. But I'm pretty sure the = 'json' here is redundant.

https://discord.com/channels/830184174198718474/1252972140161142816/1252996832238506056

Before: image

After: image

Testing

No tests are necessary here I think?

Docs

No docs are necessary as I think this is a bug fix?

changeset-bot[bot] commented 1 week ago

🦋 Changeset detected

Latest commit: 94222e731490cd8653144154505c5b3104b8c600

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR