search

withastro / astro

The web framework for content-driven websites. ⭐️ Star to support our work!
https://astro.build
Other
46.93k stars 2.49k forks source link

fix: server island hydration #12444

Closed ematipico closed 2 days ago

ematipico commented 1 week ago

Changes

Closes https://github.com/withastro/astro/issues/12421 Closes PLT-2643

The PR just adds a check if script exists, because external libs could mess up with DOM and stuff.

Testing

I tested it locally

Docs

N/A

changeset-bot[bot] commented 1 week ago

🦋 Changeset detected

Latest commit: 9b04a72c5434ec161758df5dfe3a4f4e9508d6ed

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

codspeed-hq[bot] commented 1 week ago

CodSpeed Performance Report

Merging #12444 will not alter performance

Comparing fix/server-island-script (9b04a72) with main (8e135b6)

Summary

✅ 6 untouched benchmarks