search

withastro / astro

The web framework for content-driven websites. ⭐️ Star to support our work!
https://astro.build
Other
46.93k stars 2.49k forks source link

feat: add support for server islands for `MDX` #12446

Open apatel369 opened 6 days ago

apatel369 commented 6 days ago

Changes

Closes #12252

Server Islands are not rendering as islands in .mdx files because server islands metadata is not added for JSX components in MDX files. Even after adding server islands metadata, the issue persists because transform function in vite-plugin-server-islands.ts file runs before server metadata is added in rehype.ts file.

I found that vite-plugin-server-islands.ts is added last in create-vite.ts and has enforce: 'post' but still transform function is running before the server meta data is added.

I am looking for feedback and guidance from Astro contributors on how to fix it.

Testing

TODO

Docs

Not needed

changeset-bot[bot] commented 6 days ago

⚠️ No Changeset found

Latest commit: e63f5a2ec61d2320f32ef1b425a9381f7b43b256

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR