withastro / astro

The web framework for content-driven websites. ⭐️ Star to support our work!
https://astro.build
Other
46.93k stars 2.49k forks source link

ci: remove owner check to enable external PR jobs #12466

Closed ematipico closed 4 days ago

ematipico commented 4 days ago

Changes

At the moment the PRs from non-maintainers fail the benchmark job because there's a check over the org. This PR removes that check

Testing

CI should pass

Docs

N/A

changeset-bot[bot] commented 4 days ago

⚠️ No Changeset found

Latest commit: cca60a8e09657965350a1a5ae80456465cd03469

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

codspeed-hq[bot] commented 4 days ago

CodSpeed Performance Report

Merging #12466 will not alter performance

Comparing chore/update-benchmark-job (cca60a8) with main (25baa4e)

Summary

✅ 6 untouched benchmarks

ematipico commented 4 days ago

I'm not exactly sure this fixes it, but happy to try. I thought the workflow is already running in the context of our repo, but fork PRs don't have access to our secrets.

I am also not 100% sure about the fix. I want to try to easy fix, if that doesn't work, I would need to review how the secret was created. Forks have access to our tokens in a CI context, look at the turbo tokens for example

bluwy commented 4 days ago

Forks have access to our tokens in a CI context, look at the turbo tokens for example

The turbo tokens are also not exposed for forks. They default to local cache instead of remote cache.