withastro / astro

The web framework for content-driven websites. ⭐️ Star to support our work!
https://astro.build
Other
46.98k stars 2.5k forks source link

chore: clarify wording of responsive image props #12482

Closed ascorbic closed 5 days ago

ascorbic commented 5 days ago

Changes

Improves the wording of the experimental flag docs for responsive images. Currently it says you should not set the sizes or widths values manually. This is true in some cases, but not all. This PR clarifies these, explainign when you might need it. It also ensures that the densities value is ignored if set. This was already listed as not supported, and this just aligns the actual behaviour with the docs.

Thanks @carlcs for the suggestion.

Testing

Docs

changeset-bot[bot] commented 5 days ago

⚠️ No Changeset found

Latest commit: b86c4d2fcd08f9272144d424a18a4b48d7513fa4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

ascorbic commented 3 days ago

!preview cs-test