Support for transition:persist directive

withastro / compiler

The Astro compiler. Written in Go. Distributed as WASM.

Other

503 stars 59 forks source link

Support for transition:persist directive #840

Closed matthewp closed 1 year ago

matthewp commented 1 year ago

Changes

Adds support for transition:persist. In terms of the compiler this works a lot like transition:name and transition:animate, but calls a different function createTransitionScope which creates a distinct name so that the element can be found on the new page.
Tried to add helpful comments.
Introduces experimentalPersistence because there is a new exported function, so this flag is needed to prevent breakage when using a new compiler version with an old Astro version (unlikely).

Testing

Tests are in the printer.

Docs

changeset-bot[bot] commented 1 year ago

🦋 Changeset detected

Latest commit: e625f45bb322dc02d43f0d370bf7793f80b8de2d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

| Name | Type | | ----------------- | ----- | | @astrojs/compiler | Minor |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

matthewp commented 1 year ago

!preview view-transitions

github-actions[bot] commented 1 year ago

 > root@0.0.0 release /home/runner/work/compiler/compiler > changeset publish "--tag" "next--view-transitions" 🦋 warn ===============================IMPORTANT!=============================== 🦋 warn Packages will be released under the next--view-transitions tag 🦋 warn ---------------------------------------------------------------------- 🦋 info npm info @astrojs/compiler 🦋 warn @astrojs/compiler is not being published because version 1.6.3 is already published on npm 🦋 warn No unpublished projects to publish

matthewp commented 1 year ago

!preview view-transitions

github-actions[bot] commented 1 year ago

 > root@0.0.0 release /home/runner/work/compiler/compiler > changeset publish "--tag" "next--view-transitions" 🦋 warn ===============================IMPORTANT!=============================== 🦋 warn Packages will be released under the next--view-transitions tag 🦋 warn ---------------------------------------------------------------------- 🦋 info npm info @astrojs/compiler 🦋 info @astrojs/compiler is being published because our local version (0.0.0-view-transitions-20230728203621) has not been published on npm 🦋 info Publishing "@astrojs/compiler" at "0.0.0-view-transitions-20230728203621" 🦋 success packages published successfully: 🦋 @astrojs/compiler@0.0.0-view-transitions-20230728203621 🦋 Creating git tag... 🦋 New tag: @astrojs/compiler@0.0.0-view-transitions-20230728203621

matthewp commented 1 year ago

!preview view-transitions

github-actions[bot] commented 1 year ago

 > root@0.0.0 release /home/runner/work/compiler/compiler > changeset publish "--tag" "next--view-transitions" 🦋 warn ===============================IMPORTANT!=============================== 🦋 warn Packages will be released under the next--view-transitions tag 🦋 warn ---------------------------------------------------------------------- 🦋 info npm info @astrojs/compiler 🦋 info @astrojs/compiler is being published because our local version (0.0.0-view-transitions-20230731144215) has not been published on npm 🦋 info Publishing "@astrojs/compiler" at "0.0.0-view-transitions-20230731144215" 🦋 success packages published successfully: 🦋 @astrojs/compiler@0.0.0-view-transitions-20230731144215 🦋 Creating git tag... 🦋 New tag: @astrojs/compiler@0.0.0-view-transitions-20230731144215