withastro / compiler

The Astro compiler. Written in Go. Distributed as WASM.
Other
503 stars 59 forks source link

Update compressHTML logic #916

Open natemoo-re opened 11 months ago

natemoo-re commented 11 months ago

Changes

Testing

I'd really love more comprehensive tests for this before we merge

Docs

Bug fix only

changeset-bot[bot] commented 11 months ago

🦋 Changeset detected

Latest commit: a7bae794c8345d573ac624245243b50b60c8127d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package | Name | Type | | ----------------- | ----- | | @astrojs/compiler | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

natemoo-re commented 11 months ago

!preview compact

github-actions[bot] commented 11 months ago
 > root@0.0.0 release /home/runner/work/compiler/compiler > changeset publish "--tag" "next--compact" 🦋 warn ===============================IMPORTANT!=============================== 🦋 warn Packages will be released under the next--compact tag 🦋 warn ---------------------------------------------------------------------- 🦋 info npm info @astrojs/compiler 🦋 info @astrojs/compiler is being published because our local version (0.0.0-compact-20231220212312) has not been published on npm 🦋 info Publishing "@astrojs/compiler" at "0.0.0-compact-20231220212312" 🦋 success packages published successfully: 🦋 @astrojs/compiler@0.0.0-compact-20231220212312 🦋 Creating git tag... 🦋 New tag: @astrojs/compiler@0.0.0-compact-20231220212312
florian-lefebvre commented 11 months ago

It seems that it doesn't fix whitespaces (https://github.com/florian-lefebvre/portfolio/pull/8): https://portfolio-1qbg5y00j-florian-lefebvre.vercel.app/

natemoo-re commented 11 months ago

Thanks for confirming, @florian-lefebvre! I'm picking this up again.

florian-lefebvre commented 10 months ago

@natemoo-re up!