withastro / compiler

The Astro compiler. Written in Go. Distributed as WASM.

Other

503 stars 59 forks source link

Revert "Fix slot regression when there are multiple expressions (#952)" #963

Closed MoustaphaDev closed 9 months ago

MoustaphaDev commented 9 months ago

Changes

Revert #933
Revert #952
Close https://github.com/withastro/compiler/issues/959
Close https://github.com/withastro/compiler/issues/955
Reopen https://github.com/withastro/compiler/issues/868
Reopen https://github.com/withastro/compiler/issues/724

933 ended up causing too many severe regressions so we decided to roll it back until we can do get extensive testing done for the dynamic slot feature.

Testing

Reverted all tests from these two PRs
Removed the tests added in core for this feature in https://github.com/withastro/astro/pull/9999
Added tests to close the issues

Docs

Remove the references of this feature in https://github.com/withastro/docs/pull/6793

changeset-bot[bot] commented 9 months ago

🦋 Changeset detected

Latest commit: 9d40796ebd3b90ee9978afe97d2e3bbe7d526c24

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

| Name | Type | | ----------------- | ----- | | @astrojs/compiler | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR