Closed bluwy closed 9 months ago
Latest commit: e8c2170aa127075e05edfca326f40bd106b0b4be
The changes in this PR will be included in the next version bump.
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
!preview render-script
> root@0.0.0 release /home/runner/work/compiler/compiler > changeset publish "--tag" "next--render-script" 🦋 warn ===============================IMPORTANT!=============================== 🦋 warn Packages will be released under the next--render-script tag 🦋 warn ---------------------------------------------------------------------- 🦋 info npm info @astrojs/compiler 🦋 info @astrojs/compiler is being published because our local version (0.0.0-render-script-20240214150051) has not been published on npm 🦋 info Publishing "@astrojs/compiler" at "0.0.0-render-script-20240214150051" 🦋 success packages published successfully: 🦋 @astrojs/compiler@0.0.0-render-script-20240214150051 🦋 Creating git tag... 🦋 New tag: @astrojs/compiler@0.0.0-render-script-20240214150051
What's internalURL
? I lack some context
internalURL
is one of the compiler option names. We pass something like astro/compiler-runtime
.
Let's 🚢 it
Thanks for the reviews! I'll merge this in for now then and we could get the other PRs in to cut a new minor together.
Changes
This PR allows rendering non-inline script tags using a runtime API from
internalURL
, e.g.becomes:
Personally I'm not a fan of the hardcoded script URL default, but the styles were also hardcoded this way, and it was easier to implement.
Testing
Added go tests
Docs
Only added jsdoc to the types explaining this feature. Options added in the past didn't have public docs either (?)