withastro / docs

Astro documentation
https://docs.astro.build/
MIT License
1.25k stars 1.38k forks source link

Replace vuepress@v1 with vuepress@v2 #197

Closed Mister-Hope closed 2 years ago

Mister-Hope commented 2 years ago

This is Mister-hope from VuePress team. Similar with the topic discussed in https://github.com/withastro/astro/issues/1159, I am not sure why you are comparing with our VuePress1. It has nearly no activity in any features and only rare bug fixes in last 2 years. (e.g.: 9 month between 1.8.2 and 1.8.3)

image

I suggest you should replace VuePress 1 result with V2 results (and also update the benchmarks). And our docs's netlify address is https://vuepress2.netlify.app/guide/. There are unfixable security problems on deps chain of V1, and we actually do not recommand users to use VuePress V1 for quite a long time.

image

image

Since astro and VuePress are using different logic here, VuePress needs a hydration on page load, so VuePress has a red blocking time, that do make our performance score lower. But we have a better fcp comparing with astro, and for the rest 4 items in preformance, I did not see much difference.

Mister-Hope commented 2 years ago

BTW, the 2 results are generated from https://web.dev/measure/ and our official docs link ( deployed on gh pages is at https://v2.vuepress.vuejs.org/

sarah11918 commented 2 years ago

Hi @Mister-Hope - I know we will be looking at that section of the documentation again soon for updates/refreshes, so I will make sure this is brought to @FredKSchott 's attention!

FredKSchott commented 2 years ago

Sounds good! this entire page needs an audit, I'll make sure to update to vuepress 2 when we do

sarah11918 commented 2 years ago

@Mister-Hope - I have recently rerun all of the Lighthouse reports for our Astro comparison page and updated the findings. You can see it here: https://docs.astro.build/en/comparing-astro-vs-other-tools/#vuepress-vs-astro

We did use this page for VuePress: https://v2.vuepress.vuejs.org/guide/ run with https://web.dev/measure.

Thank you for your patience, and if there's nothing further, I believe this issue can be closed now.