Re-revert "Consistent installation title"

Tc-001 commented 1 year ago

What kind of changes does this PR include?

Minor content fixes (broken links, typos, etc.)

Description

My second shot at this PR, for context see #2262 and #2265

The titles now are:

Installation (Automatic CLI)
Installation (Manual Setup)

I am using the tab names, so it should still be consistent, they also have around the same breakpoint so the line amount should match on most screen sizes

cc @delucis, let me know if this works for you

netlify[bot] commented 1 year ago

Deploy Preview for astro-docs-2 ready!

Built without sensitive environment variables

Name	Link
Latest commit	56874eb3c2d5bc5ffcee2ca8837cedb7db403f75
Latest deploy log	https://app.netlify.com/sites/astro-docs-2/deploys/63bdcf13ae06180008b8883e
Deploy Preview	https://deploy-preview-2326--astro-docs-2.netlify.app
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Tc-001 commented 1 year ago

I like it! Will make the change in a few hrs

sarah11918 commented 1 year ago

@Tc-001 - just pinging for freshness! Make Chris' changes, and it's good to merge, I think!

Tc-001 commented 1 year ago

The suggested are a bit too different in length, so the effect can be broken pretty easily, but the following works:

Install Astro with manual setup
Install Astro with the Automatic CLI

a	b

sarah11918 commented 1 year ago

What does it look like if you compare:

Install Astro Wizard

Install Astro manually

I actually like how Install Astro manually looks as a title in live docs. So, can we tighten up the Auto? Other suggestions for phrasing?

Tc-001 commented 1 year ago

a	b	c

"Install Astro automatically" just barely is smaller than the word wrap point, but unsure how it looks on other browsers Wizard works but I think the wording is a bit weird? Will see if I can come up with anything

sarah11918 commented 1 year ago

Install Astro via Wizard ??

Install Astro with Wizard ??

Tc-001 commented 1 year ago

Maybe? Still a bit strange for my taste, but they do fit!

Tc-001 commented 1 year ago

I have found some, but needing them to be around the same length is a bit limiting, I don't think there is a perfect one

Tc-001 commented 1 year ago

For me personally this makes the most sense, as it is a line and a bit in length in the largest size

But maybe it would be better to remove the tabs and make them distinctively 2 different pages? They could link to each other with something like:

"The wizard will now run some commands, if you want to know what they are or run them yourself, click here. "

Tc-001 commented 1 year ago

I think I will sleep on it, is is getting quite late Also will probably move to discord, a lot easier to paste screenshots there ~~and my email doesn't get spammed as much~~

Best of lucks to your projects!

kevinzunigacuellar commented 1 year ago

Is there any reason to keep the automatic in "automatic cli"? I think "with the cli" is simpler

Tc-001 commented 1 year ago

It could work and fits in one line! Although it wraps a lot sooner so the effect would break if the browser is not maximized, but it would do it's job ~80% of the time

sarah11918 commented 1 year ago

Coming back to this.... 😅

What about some distinction more like:

"Automatic Setup" / "Install Manually" "Wizard Setup" / "Install Manually" "Create Astro Wizard" / "Installing Manually" (I can keep editing this message all night...)

They both involve the CLI, just in one case you're installing and running the wizard, and in the other, you're just installing Astro. So, I don't think using "CLI" for one vs the other is exactly correct?
It's not the "installing" that's automatic, it's the SETUP with all the options, eh?

sarah11918 commented 1 year ago

OK! So we have a different fix for this issue.... we're going to tackle this in #2390 and kill off the fake tabs entirely! :hocho:

This is the only time we use tabs to "fake" page navigation, and it's a pattern that is clearly problematic and that we shouldn't enable. Plus, having two separate pages allows us to customize the top of the page so we can still nudge people to create astro.

Since the whole reason for this pattern was to avoid duplicating content, but now we actually want that content to be different anyway, I'm closing this issue in favour of the solution to making two entirely different pages. There's no need for this content to be this closely aligned anymore.

withastro / docs