search

withastro / docs

Astro documentation
https://docs.astro.build/
MIT License
1.33k stars 1.48k forks source link

Abount Fontsource package name #7981

Closed magurotabetai closed 6 months ago

magurotabetai commented 6 months ago

📚 Subject area/topic

Usinc custom fonts

📋 Page(s) affected (or suggested, for new content)

https://docs.astro.build/en/guides/fonts/

📋 Description of content that is out-of-date or incorrect

Since Variable Fonts in fontsource start with @fontsource-variable/, I thought it might be better to display "It will start with @fontsource/ or @fontsource-variable/ followed by the name of the font." instead of the tip "It will start with @fontsource/ followed by the name of the font."

🖥️ Reproduction in StackBlitz (if reporting incorrect content or code samples)

No response

delucis commented 6 months ago

Thank you for the issue @magurotabetai — would you like to make a PR with this change?

I checked the Fontsource docs and confirmed they are now also using that scope, see for example https://fontsource.org/fonts/inter/install

magurotabetai commented 6 months ago

I would like to gain experience contributing to OSS, so I would like to create a PR for sure!