search

withastro / docs

Astro documentation
https://docs.astro.build/
MIT License
1.23k stars 1.32k forks source link

[pull request template] Reminds new feature PRs to include `<Since>` #8173

Closed sarah11918 closed 2 weeks ago

sarah11918 commented 2 weeks ago

Description (required)

This PR adds a reminder in the PR template to use the <Since> component when adding docs for a new or updated feature in an upcoming minor release.

<!-- 2. Check that your PR includes `<p><Since v="4.x.0" /></p>` and imports the `<Since>` component, if necessary! -->

This is to provide another line of defense, as often Sarah forgets the first time editing. 😅

vercel[bot] commented 2 weeks ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview May 3, 2024 8:53pm
1 Ignored Deployment | Name | Status | Preview | Updated (UTC) | | :--- | :----- | :------ | :------ | | **docs-i18n** | ⬜️ Ignored ([Inspect](https://vercel.com/astrodotbuild/docs-i18n/3ytoaQdeACQhDeFgKyP3UnLfQwtG)) | | May 3, 2024 8:53pm |
sarah11918 commented 2 weeks ago

(Will note for historical record that <Since> can also take e.g. pkg="preact" attribute in case it's not an update to a version of Astro, but one of the packages instead. But, I'm betting on me noticing and fixing if and when that comes up! 😅

sarah11918 commented 2 weeks ago

!coauthor

github-actions[bot] commented 2 weeks ago 
Co-authored-by: Paul Valladares <85648028+dreyfus92@users.noreply.github.com>