Closed Egpereira closed 1 week ago
The latest updates on your projects. Learn more about Vercel for Git ↗︎
Name | Status | Preview | Updated (UTC) |
---|---|---|---|
docs | ✅ Ready (Inspect) | Visit Preview | May 7, 2024 0:16am |
@HiDeoo only managed to open the proposal now!
🌕 This pull request will trigger status changes.
Locale | File | Note |
---|---|---|
en | guides/testing.mdx | Source changed, localizations will be marked as outdated. |
This change makes sense! Well spotted!
I think the code blocks will need to be UN-indented, though, because the indentation was because of being inside of an ordered list.
This change makes sense! Well spotted!
I think the code blocks will need to be UN-indented, though, because the indentation was because of being inside of an ordered list.
you mean this one?
should I un-indent one tab on the code blocks (they are with currently two, doesn't affect the visual outcome)?
Oh, you're right! I was thinking that, but seeing it, it does fit. Thank you!
Hmm, just noticing that the middle one is viewing the test report. As you indicated in the section below, does this require first running one of the above tests?
I wonder whether we should at least reorder and put viewing the report at the bottom?
Hmm, just noticing that the middle one is viewing the test report. As you indicated in the section below, does this require first running one of the above tests?
I wonder whether we should at least reorder and put viewing the report at the bottom?
I see now! It makes sense to me 🤔 What do you think about having the first two steps considered as the same one, with different options, followed by the report one as a second step, similar to the Playwright section? Is it too weird?
I might even suggest a small wording change for the second example (also changed back the phrase before the steps to "CLI steps").
I think it's not too weird! At some point we may revisit the page as a whole, but I say for now, your judgement makes sense! 2 steps for running/reporting, then present the other as an alternate.
I think it's not too weird! At some point we may revisit the page as a whole, but I say for now, your judgement makes sense! 2 steps for running/reporting, then present the other as an alternate.
Commited the changes as discussed!
Looks great, let's do it! 💪
Update lists in
testing.mdx
As commented here: https://github.com/withastro/docs/pull/8096#issuecomment-2091086809, this PR proposes a change to two lists in the
testing.mdx
file:Steps
component, since they are actually instructions than only can run one after the other.