search

withastro / docs

Astro documentation
https://docs.astro.build/
MIT License
1.23k stars 1.32k forks source link

Sidebar Reorganization Implementation #8197

Open SatanshuMishra opened 1 week ago

SatanshuMishra commented 1 week ago

Description (required)

This PR aims to implement the changes proposed in #6845. The changes made include:

  1. Contribute Section was removed from the RightSideBar.
  2. The Translate option was moved beside the Edit Page option at the bottom of the page above the Pagination.
  3. A new References component was created to hold the links to the Contribute, Give Feedback, and Community pages.
  4. A custom Footer component created to override the default Starlight Footer. The Pagination, EditLinks, & References components were added to this component (as before). The LastUpdated component was also added (commented out) for possible future development.
  5. Added custom icons for Give Feedback and Community options.

Related issues & labels (optional)

Preview of changed: Current Implementation: image

Proposed Changes: image

Special thanks to @delucis for coming up with the design and guidance throughout this implementation.

vercel[bot] commented 1 week ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview May 8, 2024 2:45am
SatanshuMishra commented 1 week ago

Thank you for putting this together @SatanshuMishra! Really appreciate you picking it up. I’ve left some initial feedback.

There are probably also two details to discuss:

  • Are we happy with this also being added to the homepage? (My gut instinct is yes, it’s nice.) footer of docs homepage in preview deployment showing the added footer links to “Contribute”, “Give us feedback”, and “Community”
  • Whether we want any extra space between the pagination links and the new footer links. Curious what others think on this one.

I think this looks good too @delucis! Certainly nice to give people to learn about how to contribute, give us feedback or see the amazing community page we have.

adaliszk commented 3 days ago

Overall, it would look better if both the link lists were always aligned to the center, perhaps even with a top border to separate the footer from the rest of the content. Another thing that might be worthwhile to do is on mobile screens. The links would be excellent if they were bigger and had full-width rows, so it's easy to tap on them.