search

withastro / language-tools

Language tools for Astro
MIT License
242 stars 46 forks source link

AstroJSX syntax [WIP] #828

Open goulvenclech opened 4 months ago

goulvenclech commented 4 months ago

Changes

Astro expression syntax is similar to JSX, but it's not JSX. So, we need to create a new syntax for it, including the JSX syntax as a base, and adding some Astro-specific patterns over it.

This will allow us to fix some issues much more easily, such as #708 or #714 . Also, the syntax will match the actual behaviour of Astro expressions, like basic HTML comments - not supported by JSX in expressions, but Astro does.

Testing

Will be tested. I swear.

Docs

N/A, this PR will make the syntax match the actual behaviour of Astro expressions. But the code is commented.

changeset-bot[bot] commented 4 months ago

⚠️ No Changeset found

Latest commit: 9ebaa55517df1205b1a380e0484f3e3a706c0091

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR