search

withastro / language-tools

Language tools for Astro
MIT License
240 stars 45 forks source link

fix(syntax): Apply JSX latest rules for our language #858

Closed Princesseuh closed 2 months ago

Princesseuh commented 2 months ago

Changes

Add a few more things from TSX's syntax to our rules that are not inherited due to a VS Code bug.

Fixes https://github.com/withastro/language-tools/issues/713 and a few unreported issues (ex: >>>= wasn't properly highlighted

Testing

Tested manually, you can't test this inside grammar tests because you don't see the underlying language being applied, just the source.tsx scope.

Docs

N/A

changeset-bot[bot] commented 2 months ago

🦋 Changeset detected

Latest commit: 909276988a95f3f7785b6cdbc8e7c191ed34ac5a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package | Name | Type | | ------------ | ----- | | astro-vscode | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Princesseuh commented 2 months ago

Test failure is unrelated to the change (the test it's trying to run but failing doesn't test this), not sure what's happening

Princesseuh commented 2 months ago

Oh, it's a Node change https://github.com/nodejs/node/issues/52554