search

withastro / language-tools

Language tools for Astro
MIT License
240 stars 45 forks source link

feat: Upgrade to Volar 2.2 #863

Closed johnsoncodehk closed 2 months ago

johnsoncodehk commented 2 months ago

Changes

Upgrade to Volar 2.2 💪

Testing

Docs

changeset-bot[bot] commented 2 months ago

🦋 Changeset detected

Latest commit: b41458f8faa73b84926d815f36fcd3a3792f8a38

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages | Name | Type | | ------------------------ | ----- | | @astrojs/check | Minor | | @astrojs/language-server | Minor | | @astrojs/ts-plugin | Minor | | astro-vscode | Minor |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Princesseuh commented 2 months ago

Tried this PR locally and it seems to work, however I noticed an issue with the Prettier formatting, seems like it's not loading the Prettier config anymore.

Not quite sure what's up with the tests, but since the features do work locally I can only assume this is a bug in the test utils / tests

Princesseuh commented 2 months ago

@johnsoncodehk My last commit fixes some of the tests. However, it seems like there's an issue with openInMemoryDocument in Volar 2.2, all the remaining tests that don't pass uses it.

Strangely enough, if I change the fake URI to be one of a file that does exist, no matter its content, then it works.