withastro / language-tools

Language tools for Astro
MIT License
267 stars 52 forks source link

🐛 BUG: Installation of `@astrojs/react` leads to failure of `astro check` #885

Closed metters closed 3 months ago

metters commented 3 months ago

Describe the Bug

astro check worked before I installed @astrojs/react, but now it does not anymore.

The expected value of satori changes from VNode to ReactNode due to that installation:

Screenshot 2024-06-25 at 21 41 41

The run of the GitHub Action failed on the updated branch.

Before that it still worked (see other runs before, there are only two previous runs, both without @astrojs/react).

Is this a satori bug or an astro bug? Sorry, if this is the wrong repository to open an issue!

Thank you very much in advance!

Steps to Reproduce

Princesseuh commented 3 months ago

This is unrelated to astro check, it's a quirk of how Satori works. When installing the React integration, you also install the types for React, which Satori then automatically uses.